Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add always_publish arg #134

Merged
merged 5 commits into from
Dec 15, 2023
Merged

Add always_publish arg #134

merged 5 commits into from
Dec 15, 2023

Conversation

tkmtnt7000
Copy link
Member

@tkmtnt7000 tkmtnt7000 commented Jun 26, 2023 •
edited
Loading

I added ~always_publish arg because since then edgetpu nodes publish topic whether or not they have recognition results.

I referred this PR (https://github.com/jsk-ros-pkg/jsk_recognition/pull/2744/files#diff-2dbcced88e36ff84629a2ef9f83dc3a39c38ad92553424d05adc2b17278a5f07R118-R120).

knorth55
knorth55 requested changes Jun 26, 2023
View reviewed changes
python/coral_usb/human_pose_estimator.py Outdated Show resolved Hide resolved
python/coral_usb/node_base.py Show resolved Hide resolved
@knorth55
Copy link
Member

please update the doc in readme.md

@tkmtnt7000 tkmtnt7000 mentioned this pull request Jun 27, 2023
Open
@tkmtnt7000
Copy link
Member Author

Thank you for reviewing.
I update the document.

@knorth55 knorth55 merged commit 87bf4a0 into jsk-ros-pkg:master Dec 15, 2023
@tkmtnt7000 tkmtnt7000 deleted the always-subscribe branch December 15, 2023 23:16
@tkmtnt7000 tkmtnt7000 mentioned this pull request Dec 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sktometometo sktometometo sktometometo approved these changes

@knorth55 knorth55 knorth55 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tkmtnt7000 @knorth55 @sktometometo